ArcsinX wrote:

> Hello. I have completed the changes locally and verified them myself; could 
> you please take a look? I'v changed `const MainFileMacros &Macros` to 
> `MainFileMacros Macros` just like `Includes`.

Thanks. But this was just a question. maybe we can use a reference :)
If we use a copy, maybe you can provide some number about memory usage changes. 
E.g. at opening a heavy file like clang/lib/Sema/Sema.cpp with disabled 
background indexer, do we see any significant changes in memory usage with and 
without this patch?


Can you please fix formatting of your changes? You can use clang-format (or 
format feature of clangd) to do this.

https://github.com/llvm/llvm-project/pull/202495
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to