hokein added a comment. Sorry for the delay. I saw you have reverted this commit somehow. A post commit.
================ Comment at: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp:113 Rules.push_back(createRefactoringActionRule<RenameOccurrences>( - SymbolSelectionRequirement())); + SymbolSelectionRequirement(), OptionRequirement<NewNameOption>())); return Rules; ---------------- Thought it a bit more: it requires all of the requirements are satisfied, I think we need to support "one-of" option. For example, we have two option "-a" and "-b", only one of them is allowed to be present at the same time. Repository: rL LLVM https://reviews.llvm.org/D37856 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits