jlebar added a comment. My only regret is that I have but one +1 to give to this patch.
================ Comment at: include/clang/Basic/AddressSpaces.h:51 +namespace LanguageAS { /// The type of a lookup table which maps from language-specific address spaces ---------------- I wonder if you need this namespace? LangAS right next to LanguageAS reads strangely to me -- "what's the difference?". I guess you'd need to rename Map and fromTargetAS, but the other two members are probably OK? Repository: rL LLVM https://reviews.llvm.org/D38816 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits