https://github.com/theSK2005 updated https://github.com/llvm/llvm-project/pull/203313
>From 5a599128772a969d862b37fac79127daf907fbc1 Mon Sep 17 00:00:00 2001 From: Soumil Kushwaha <[email protected]> Date: Thu, 11 Jun 2026 10:40:14 -0500 Subject: [PATCH 1/3] Made SRAMECC feature fix for gfx1250/1251 --- llvm/include/llvm/TargetParser/AMDGPUTargetParser.def | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/llvm/include/llvm/TargetParser/AMDGPUTargetParser.def b/llvm/include/llvm/TargetParser/AMDGPUTargetParser.def index 191b8e4672082..13946d8aa25c3 100644 --- a/llvm/include/llvm/TargetParser/AMDGPUTargetParser.def +++ b/llvm/include/llvm/TargetParser/AMDGPUTargetParser.def @@ -123,8 +123,8 @@ AMDGCN_GPU ("gfx1171", GK_GFX1171, (11, 7, 1), FEATURE_FAST_FMA_F32|FEAT AMDGCN_GPU ("gfx1172", GK_GFX1172, (11, 7, 2), FEATURE_FAST_FMA_F32|FEATURE_FAST_DENORMAL_F32|FEATURE_WAVE32|FEATURE_WGP) AMDGCN_GPU ("gfx1200", GK_GFX1200, (12, 0, 0), FEATURE_FAST_FMA_F32|FEATURE_FAST_DENORMAL_F32|FEATURE_WAVE32|FEATURE_WGP) AMDGCN_GPU ("gfx1201", GK_GFX1201, (12, 0, 1), FEATURE_FAST_FMA_F32|FEATURE_FAST_DENORMAL_F32|FEATURE_WAVE32|FEATURE_WGP) -AMDGCN_GPU ("gfx1250", GK_GFX1250, (12, 5, 0), FEATURE_FAST_FMA_F32|FEATURE_FAST_DENORMAL_F32|FEATURE_WAVE32|FEATURE_XNACK_ALWAYS) -AMDGCN_GPU ("gfx1251", GK_GFX1251, (12, 5, 1), FEATURE_FAST_FMA_F32|FEATURE_FAST_DENORMAL_F32|FEATURE_WAVE32|FEATURE_XNACK_ALWAYS) +AMDGCN_GPU ("gfx1250", GK_GFX1250, (12, 5, 0), FEATURE_FAST_FMA_F32|FEATURE_FAST_DENORMAL_F32|FEATURE_WAVE32|FEATURE_XNACK_ALWAYS|FEATURE_SRAMECC) +AMDGCN_GPU ("gfx1251", GK_GFX1251, (12, 5, 1), FEATURE_FAST_FMA_F32|FEATURE_FAST_DENORMAL_F32|FEATURE_WAVE32|FEATURE_XNACK_ALWAYS|FEATURE_SRAMECC) AMDGCN_GPU ("gfx1310", GK_GFX1310, (13, 1, 0), FEATURE_FAST_FMA_F32|FEATURE_FAST_DENORMAL_F32|FEATURE_WAVE32|FEATURE_WGP) // Generic targets return the lowest common denominator >From 7e7fe07716abb562d7648620a002208bd012acf0 Mon Sep 17 00:00:00 2001 From: Soumil Kushwaha <[email protected]> Date: Mon, 15 Jun 2026 13:31:42 -0500 Subject: [PATCH 2/3] added d gfx1250/1251 SRAMECC tests --- clang/test/Driver/amdgpu-xnack-sramecc-flags.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/clang/test/Driver/amdgpu-xnack-sramecc-flags.c b/clang/test/Driver/amdgpu-xnack-sramecc-flags.c index c40dabcd4f645..8f5a3a4337600 100644 --- a/clang/test/Driver/amdgpu-xnack-sramecc-flags.c +++ b/clang/test/Driver/amdgpu-xnack-sramecc-flags.c @@ -64,6 +64,18 @@ // TARGETID-BOTH: "-target-feature" "+xnack" // TARGETID-BOTH-SAME: "-target-feature" "+sramecc" +// RUN: %clang -### --target=amdgcn-amd-amdhsa -mcpu=gfx1250:sramecc+ %s 2>&1 | \ +// RUN: FileCheck -check-prefix=SRAMECC-ON %s + +// RUN: %clang -### --target=amdgcn-amd-amdhsa -mcpu=gfx1250:sramecc- %s 2>&1 | \ +// RUN: FileCheck -check-prefix=SRAMECC-OFF %s + +// RUN: %clang -### --target=amdgcn-amd-amdhsa -mcpu=gfx1251:sramecc+ %s 2>&1 | \ +// RUN: FileCheck -check-prefix=SRAMECC-ON %s + +// RUN: %clang -### --target=amdgcn-amd-amdhsa -mcpu=gfx1251:sramecc- %s 2>&1 | \ +// RUN: FileCheck -check-prefix=SRAMECC-OFF %s + // // Offload tests // >From 348880f1f99a2b2a95a5a5c403031c36490ba19c Mon Sep 17 00:00:00 2001 From: Soumil Kushwaha <[email protected]> Date: Mon, 15 Jun 2026 15:50:33 -0500 Subject: [PATCH 3/3] moving gfx1250/12511 sramecc tests to amdgpu-features.c --- clang/test/Driver/amdgpu-features.c | 12 ++++++++++++ clang/test/Driver/amdgpu-xnack-sramecc-flags.c | 12 ------------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/clang/test/Driver/amdgpu-features.c b/clang/test/Driver/amdgpu-features.c index c756b91379180..a3ac4e443aec7 100644 --- a/clang/test/Driver/amdgpu-features.c +++ b/clang/test/Driver/amdgpu-features.c @@ -10,6 +10,18 @@ // RUN: %clang -### --target=amdgcn-amdhsa -mcpu=gfx908:sramecc- -nogpulib %s 2>&1 | FileCheck --check-prefix=NO-SRAM-ECC %s // NO-SRAM-ECC: "-target-feature" "-sramecc" +// RUN: %clang -### --target=amdgcn-amd-amdhsa -mcpu=gfx1250:sramecc+ %s 2>&1 | \ +// RUN: FileCheck -check-prefix=SRAM-ECC %s + +// RUN: %clang -### --target=amdgcn-amd-amdhsa -mcpu=gfx1250:sramecc- %s 2>&1 | \ +// RUN: FileCheck -check-prefix=NO-SRAM-ECC %s + +// RUN: %clang -### --target=amdgcn-amd-amdhsa -mcpu=gfx1251:sramecc+ %s 2>&1 | \ +// RUN: FileCheck -check-prefix=SRAM-ECC %s + +// RUN: %clang -### --target=amdgcn-amd-amdhsa -mcpu=gfx1251:sramecc- %s 2>&1 | \ +// RUN: FileCheck -check-prefix=NO-SRAM-ECC %s + // RUN: %clang -### -target amdgcn -mcpu=gfx90a -mtgsplit %s 2>&1 | FileCheck --check-prefix=TGSPLIT %s // RUN: %clang -### -target amdgcn -mcpu=gfx90a -mno-tgsplit %s 2>&1 | FileCheck --check-prefix=NO-TGSPLIT %s // TGSPLIT: "-target-feature" "+tgsplit" diff --git a/clang/test/Driver/amdgpu-xnack-sramecc-flags.c b/clang/test/Driver/amdgpu-xnack-sramecc-flags.c index 8f5a3a4337600..c40dabcd4f645 100644 --- a/clang/test/Driver/amdgpu-xnack-sramecc-flags.c +++ b/clang/test/Driver/amdgpu-xnack-sramecc-flags.c @@ -64,18 +64,6 @@ // TARGETID-BOTH: "-target-feature" "+xnack" // TARGETID-BOTH-SAME: "-target-feature" "+sramecc" -// RUN: %clang -### --target=amdgcn-amd-amdhsa -mcpu=gfx1250:sramecc+ %s 2>&1 | \ -// RUN: FileCheck -check-prefix=SRAMECC-ON %s - -// RUN: %clang -### --target=amdgcn-amd-amdhsa -mcpu=gfx1250:sramecc- %s 2>&1 | \ -// RUN: FileCheck -check-prefix=SRAMECC-OFF %s - -// RUN: %clang -### --target=amdgcn-amd-amdhsa -mcpu=gfx1251:sramecc+ %s 2>&1 | \ -// RUN: FileCheck -check-prefix=SRAMECC-ON %s - -// RUN: %clang -### --target=amdgcn-amd-amdhsa -mcpu=gfx1251:sramecc- %s 2>&1 | \ -// RUN: FileCheck -check-prefix=SRAMECC-OFF %s - // // Offload tests // _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
