Meinersbur wrote: > I've rebased this PR, but the changes that were needed to make all of the > `check-flang` tests pass do seriously worry me:
Which changes? I only see `BufSize` and `offload-device.f90` need adaptation, outside adding the initial infrastructure. > people will be introducing the changes that will be breaking the > perf-training builds, and it will be the responsibility of those unfortunates > who rely on that to fix those breaking changes. Sadly, one of those > unfortunates will be me. This makes me wonder if we're doing the right thing > re-using the `check-flang` test suite for a new purpose. > It becomes more and more apparent. But what the alternative would be? Create an RFC on Discourse then? Otherwise, I would actually greenlight this PR. https://github.com/llvm/llvm-project/pull/198863 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
