jhuber6 wrote:

> I mean, I am in favor of this landing. I can see why having it on by default 
> is counterproductive. All I was saying is that I was just not in favor of 
> this landing w/ issues known and ignored. If the issues are filed, even if 
> they're not fixed anytime, LGTM.

Yeah, this does effectively lose testing support. We should probably figure out 
which builds benefit greatly from it and pass it manually there.

If you wanted really good test coverage you could probably try compiling the 
LLVM libc test suite with it, probably the the most complicated multi-TU case 
we have. I remember it was totally broken last time we tried when the 
`-flto-paritions` was default for all AMDGPU.

https://github.com/llvm/llvm-project/pull/203948
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to