================
@@ -277,22 +277,27 @@ RValue
CodeGenFunction::EmitCXXMemberOrOperatorMemberCallExpr(
}
}
- LValue This;
- if (IsArrow) {
- LValueBaseInfo BaseInfo;
- TBAAAccessInfo TBAAInfo;
- Address ThisValue = EmitPointerWithAlignment(Base, &BaseInfo, &TBAAInfo);
- This = MakeAddrLValue(ThisValue, Base->getType()->getPointeeType(),
- BaseInfo, TBAAInfo);
- } else {
- This = EmitLValue(Base);
- }
+ auto getLValueForThis = [this, IsArrow,
+ Base](bool EmitCheckedForStore = false) {
+ // FIXME: Respect EmitCheckedForStore for the IsArrow case.
----------------
hubert-reinterpretcast wrote:
I don't think that is necessary. Pre-committing tests is generally a strategy
used _if_ it is thought to assist in the review of an imminent fix by reducing
the size of test changes to be reviewed. We can consider this in the context of
the fix for the FIXME (for info, that is coming in the next few days).
https://github.com/llvm/llvm-project/pull/203737
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
