[clang] [clang][driver][darwin] DarwinSDKInfo doesn't match sufficiently modified triples, doesn't warn for unsupported architectures (PR #204061)

[Steven Wu via cfe-commits]

================
@@ -195,6 +273,8 @@ DarwinSDKInfo::parseDarwinSDKSettingsJSON(std::string 
FilePath,
   PlatformInfoStorageType PlatformInfos =
       parsePlatformInfos(*Obj, XcodePlatform, OSAndEnvironment.first,
                          OSAndEnvironment.second, *Version);
+  if (PlatformInfos.empty())
----------------
cachemeifyoucan wrote:

I see. If the assert is not supposed to trigger with all SDKSetting.json, then 
it is probably fine. fatalError might still be better since it will be a clear 
message about compiler error. 

https://github.com/llvm/llvm-project/pull/204061
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits