https://github.com/NeKon69 commented:

That's pretty complex. 2 initial thoughts:
1. Maybe add a generic getUseLoc or similar to abstract the 
implicit/non-implicit use locs.
2. Add tests for CXXDeleteExpr? I found that you have some logic for that in 
report functions but I did not see any tests.
Also I am starting to get a little concerned about our `issuePendingWarnings` 
method because it's getting much bigger, maybe we can split it up somehow (like 
reportGlobal, reportUAS, etc).

https://github.com/llvm/llvm-project/pull/204650
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to