sipher-01 wrote:

Thanks for the feedback! I've updated the title.

For the test, I plan to add a second RUN line to 
clang/test/Sema/LifetimeSafety/dangling-global.cpp:

// RUN: %clang_cc1 -fsyntax-only -Wlifetime-safety-all -Wno-dangling -verify %s

This reuses all the existing expected-warning and expected-note annotations in 
the file to verify that -Wlifetime-safety-all now correctly implies 
-Wlifetime-safety-dangling-global-moved through the LifetimeSafetyStrict group.
Could you confirm:

-Is dangling-global.cpp the right file to add the test to, or would you prefer 
a different location?
-Is a single extra RUN line sufficient, or do you want a dedicated test case 
specifically exercising the -moved variant?

https://github.com/llvm/llvm-project/pull/204891
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to