zaks.anna added a comment.
Looks like the need to have the checker name in BugType along with the checker
names not being initialized early enough, leads to worse checker-writer
experience. Is there a way to ensure that the checker names are set at
construction?
================
Comment at: lib/StaticAnalyzer/Checkers/BlockInCriticalSectionChecker.cpp:131
<< "' inside of critical section";
- auto R = llvm::make_unique<BugReport>(*BlockInCritSectionBugType, os.str(),
ErrNode);
+ if (!BlockInCritSectionBugType)
+ BlockInCritSectionBugType.reset(
----------------
nit: I prefer to use '{' here since the if body spans multiple lines.
================
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:308
if (StOutBound && !StInBound) {
+ if (!Filter.CheckCStringOutOfBounds)
+ return state;
----------------
This seems to be related to the change in the test, correct? In the future,
please, split changes like this one into their own separate commits.
https://reviews.llvm.org/D37437
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
