[clang-tools-extra] [clang-tidy] Fix crash in `cppcoreguidelines-pro-type-member-init` with alias template in constructor initializer (PR #192786)

[Yanzuo Liu via cfe-commits]

================
@@ -571,9 +571,13 @@ void 
ProTypeMemberInitCheck::checkMissingBaseClassInitializer(
       return;
 
     for (const CXXCtorInitializer *Init : Ctor->inits())
-      if (Init->isBaseInitializer() && Init->isWritten())
-        BasesToInit.erase(
-            Init->getBaseClass()->getAsCXXRecordDecl()->getCanonicalDecl());
+      if (Init->isBaseInitializer() && Init->isWritten()) {
+        // In template AST BaseInitializer could be generated too even if it's
+        // not target to base class.
----------------
zwuis wrote:

I meant this comment is wrong.

The fix is correct indeed.

https://github.com/llvm/llvm-project/pull/192786
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits