klimek added a comment. Whee, thanks for driving this, much appreciated :D
================ Comment at: include/clang/FrontendTool/Utils.h:25 + +std::unique_ptr<FrontendAction> CreateFrontendAction(CompilerInstance &CI); ---------------- Please add a comment now that this is exported. ================ Comment at: include/clang/Sema/TemplateInstCallbacks.h:32 + /// \brief Called before doing AST-parsing. + void initialize(const Sema &TheSema) { + this->initializeImpl(TheSema); ---------------- Note sure how others think about this, but I'd have expected the design to have: a) a pure interface b) an implementation TemplateInstantiationCallbacksCollection or somesuch that has a vector of TICs and forwards calls on them https://reviews.llvm.org/D5767 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits