timon-ul wrote: This technically does not fix the problem if multiple declarations have different parameter names, then we still surface inconsistent results between AST and Index (but I guess this might be rare enough to not matter? Also fixing this sounds really annoying.
The other thing to I just thought about is that I currently check for every parameter for the identifier. I could just go through the function redeclarations once and pick the first one that has a parameter name for the first parameter (or some variation of this), honestly probably faster and most of the times it will be the same result. Also the question is if it would be fine to just replace the function with a redeclaration in `AddFunctionParameterChunks` or if other information taking from the function we rather take from the original function. Lastly I cannot fix this directly in `FormatFunctionParameter` since it lacks the function declaration, but that function has a lot of callers so question is if this adjustment should be done in more calles. https://github.com/llvm/llvm-project/pull/206716 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
