ioeric added inline comments.
================ Comment at: include/clang/Tooling/CommonOptionsParser.h:115 + + static llvm::Error init(int &argc, const char **argv, + llvm::cl::OptionCategory &Category, ---------------- hokein wrote: > We can get rid of the `static` here by calling `parser->init(XXX)`. Ha, right! ================ Comment at: lib/Tooling/CommonOptionsParser.cpp:165 + const char *Overview) { + std::unique_ptr<CommonOptionsParser> Parser(new CommonOptionsParser); + llvm::Error Err = ---------------- hokein wrote: > nit: using llvm::make_unique. `make_unique` didn't work because the constructor here is private... https://reviews.llvm.org/D39042 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits