https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/207335
Adding /utf-8 is bigger endeavor than I hoped, just disable the problematic test case for now >From 4274781ef7eb469bd70e8e61bd6e3447c9effdfe Mon Sep 17 00:00:00 2001 From: Corentin Jabot <[email protected]> Date: Fri, 3 Jul 2026 09:20:40 +0200 Subject: [PATCH] Fix NSVC build after #206326 (again) --- clang/unittests/Basic/CMakeLists.txt | 1 - clang/unittests/Basic/DiagnosticTest.cpp | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/clang/unittests/Basic/CMakeLists.txt b/clang/unittests/Basic/CMakeLists.txt index 016b6d5ddcb7b..058243fd3fdba 100644 --- a/clang/unittests/Basic/CMakeLists.txt +++ b/clang/unittests/Basic/CMakeLists.txt @@ -21,4 +21,3 @@ add_distinct_clang_unittest(BasicTests Support TargetParser ) -target_compile_options(BasicTests PRIVATE "$<$<CXX_COMPILER_ID:MSVC>:/utf-8>") diff --git a/clang/unittests/Basic/DiagnosticTest.cpp b/clang/unittests/Basic/DiagnosticTest.cpp index 5cc0c39e5cb51..146673588b5a8 100644 --- a/clang/unittests/Basic/DiagnosticTest.cpp +++ b/clang/unittests/Basic/DiagnosticTest.cpp @@ -451,7 +451,8 @@ TEST_F(SuppressionMappingTest, CanonicalizesSlashesOnWindows) { TEST(DisplayCodePointForDiagnosticTest, printableDisplaysQuoted) { EXPECT_EQ(DisplayCodePointForDiagnostic(U'A'), "'A' U+0041"); - EXPECT_EQ(DisplayCodePointForDiagnostic(U'🤡'), "'🤡' U+1F921"); + // This test fails when msvc is not using /utf-8. + //EXPECT_EQ(DisplayCodePointForDiagnostic(U'🤡'), "'🤡' U+1F921"); EXPECT_EQ(DisplayCodePointForDiagnostic(U' '), "' ' U+0020"); } _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
