Author: Corentin Jabot Date: 2026-07-03T08:07:54Z New Revision: 473b0a3b727a89140762b558d74520915bd164ff
URL: https://github.com/llvm/llvm-project/commit/473b0a3b727a89140762b558d74520915bd164ff DIFF: https://github.com/llvm/llvm-project/commit/473b0a3b727a89140762b558d74520915bd164ff.diff LOG: Fix MSVC build after #206326 (again) (#207335) Adding /utf-8 is bigger endeavor than I hoped, just disable the problematic test case for now Added: Modified: clang/unittests/Basic/CMakeLists.txt clang/unittests/Basic/DiagnosticTest.cpp Removed: ################################################################################ diff --git a/clang/unittests/Basic/CMakeLists.txt b/clang/unittests/Basic/CMakeLists.txt index 016b6d5ddcb7b..058243fd3fdba 100644 --- a/clang/unittests/Basic/CMakeLists.txt +++ b/clang/unittests/Basic/CMakeLists.txt @@ -21,4 +21,3 @@ add_distinct_clang_unittest(BasicTests Support TargetParser ) -target_compile_options(BasicTests PRIVATE "$<$<CXX_COMPILER_ID:MSVC>:/utf-8>") diff --git a/clang/unittests/Basic/DiagnosticTest.cpp b/clang/unittests/Basic/DiagnosticTest.cpp index 5cc0c39e5cb51..0ed282cf38da9 100644 --- a/clang/unittests/Basic/DiagnosticTest.cpp +++ b/clang/unittests/Basic/DiagnosticTest.cpp @@ -451,7 +451,8 @@ TEST_F(SuppressionMappingTest, CanonicalizesSlashesOnWindows) { TEST(DisplayCodePointForDiagnosticTest, printableDisplaysQuoted) { EXPECT_EQ(DisplayCodePointForDiagnostic(U'A'), "'A' U+0041"); - EXPECT_EQ(DisplayCodePointForDiagnostic(U'🤡'), "'🤡' U+1F921"); + // This test fails when msvc is not using /utf-8. + // EXPECT_EQ(DisplayCodePointForDiagnostic(U'🤡'), "'🤡' U+1F921"); EXPECT_EQ(DisplayCodePointForDiagnostic(U' '), "' ' U+0020"); } _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
