================
@@ -801,9 +801,11 @@ Tool *ToolChain::getTool(Action::ActionClass AC) const {
   case Action::VerifyDebugInfoJobClass:
   case Action::BinaryAnalyzeJobClass:
   case Action::BinaryTranslatorJobClass:
-  case Action::ObjcopyJobClass:
     llvm_unreachable("Invalid tool kind.");
 
+  case Action::ObjcopyJobClass:
+    return nullptr;
----------------
mstorsjo wrote:

Why is this change needed here? Isn't this overridden for the specific target 
toolchains that implement it? Doesn't this make it a silent no-op rather than 
hitting an `llvm_unreachable` if another toolchain would get here?

https://github.com/llvm/llvm-project/pull/207612
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to