Pierre-vh wrote: > > Do not allow the type in struct fields. > > I thought we wanted to allow that so that you can write thin wrapper classes > that just contain a single instance of the underlying named barrier type.
Are there any examples of this being actually used either upstream or downstream ? We can still have wrapper objects, just with a different constructor (pass a pointer to the barrier GV in the ctor instead of letting the class allocate it, which is cleaner given how this is allocated IMO) The main issue is if there are objects mixing normal types and the barrier type, then we cannot deal with those in a sane way unless we forget putting barriers into a separate AS. https://github.com/llvm/llvm-project/pull/207687 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
