OmarAzizi wrote: > Personally I want to name this check `modernize-unused-variables` to support > > * adding `[[maybe_unused]]` instead of renaming the variable to `_` > (controlled by an option) > * 'simple' variables > > in future. > > But, I want fixits to add `[[maybe_unused]]` by default, because > `[[maybe_unused]]` is introduced earlier and it works with `assert`, so I'd > like to keep this name and make it an alias in future. (changing default > fixits is a kind of breaking changes to me)
That makes sense, especially the point about not wanting to silently change default fixit behavior. Just to make sure I'm reading this right: is this a longer-term direction you wanted to flag, or something you'd want resolved before this PR can merge? Happy to go either way. https://github.com/llvm/llvm-project/pull/207604 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
