arsenm wrote: > The builtin infrastructure can perform this check automatically, and that's > how all the other builtins handle it today.
This is not true, this is how all of the sampler cases are checked today. There are other ugly looking manual uses of evaluateRequiredTargetFeatures here in Sema > If you don't think this is the right place for the check, I'd rather move > the generic feature check somewhere else. Yes, it should be moved. But not in this PR (nor should it block this PR). https://github.com/llvm/llvm-project/pull/205367 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
