kovdan01 wrote: @atrosinenko Thanks for highlighiting the problem of insufficient test coverage! I have added several new checks to existing GOT-related tests in llvm/test/CodeGen/AArch64: see 309be5aad918002cfcfdbc677ceafb7341c52e5f
So, now we would check that regular non-auth code generation path is taken both in case of "ptrauth-elf-got" module flag being absent and this flag being present but set to 0 - per your suggestion. I'm not excited about a bunch of new RUN lines though, but I don't have any better idea how to make this testing cleaner. I would appreciate if you share your ideas if you have some :) For the ptrauth-sign-personality - it is already adequately covered by llvm/test/CodeGen/AArch64/ptrauth-sign-personality.ll, so no test changes were introduced w.r.t. this flag. Please let me know if your concerns are now resolved or there are still some gaps/issues https://github.com/llvm/llvm-project/pull/204226 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
