llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Anonmiraj (AnonMiraj) <details> <summary>Changes</summary> While benchmarking I noticed that #<!-- -->118003 causes a small compile-time regression. Right now, it computes `isCurrentInstantiation` for every base during name lookup. We can easily avoid this overhead by only computing it when a dependent base could actually be skipped. --- Full diff: https://github.com/llvm/llvm-project/pull/208139.diff 1 Files Affected: - (modified) clang/lib/AST/CXXInheritance.cpp (+11-10) ``````````diff diff --git a/clang/lib/AST/CXXInheritance.cpp b/clang/lib/AST/CXXInheritance.cpp index 29f5916284ebb..a8905f0e48ef5 100644 --- a/clang/lib/AST/CXXInheritance.cpp +++ b/clang/lib/AST/CXXInheritance.cpp @@ -162,22 +162,23 @@ bool CXXBasePaths::lookupInBases(ASTContext &Context, QualType BaseType = Context.getCanonicalType(BaseSpec.getType()).getUnqualifiedType(); - bool isCurrentInstantiation = isa<InjectedClassNameType>(BaseType); - if (!isCurrentInstantiation) { - if (auto *BaseRecord = cast_if_present<CXXRecordDecl>( - BaseSpec.getType()->getAsRecordDecl())) - isCurrentInstantiation = BaseRecord->isDependentContext() && - BaseRecord->isCurrentInstantiation(Record); - } // C++ [temp.dep]p3: // In the definition of a class template or a member of a class template, // if a base class of the class template depends on a template-parameter, // the base class scope is not examined during unqualified name lookup // either at the point of definition of the class template or member or // during an instantiation of the class tem- plate or member. - if (!LookupInDependent && - (BaseType->isDependentType() && !isCurrentInstantiation)) - continue; + if (!LookupInDependent && BaseType->isDependentType()) { + bool isCurrentInstantiation = isa<InjectedClassNameType>(BaseType); + if (!isCurrentInstantiation) { + if (auto *BaseRecord = cast_if_present<CXXRecordDecl>( + BaseSpec.getType()->getAsRecordDecl())) + isCurrentInstantiation = BaseRecord->isDependentContext() && + BaseRecord->isCurrentInstantiation(Record); + } + if (!isCurrentInstantiation) + continue; + } // Determine whether we need to visit this base class at all, // updating the count of subobjects appropriately. `````````` </details> https://github.com/llvm/llvm-project/pull/208139 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
