https://github.com/balazske created https://github.com/llvm/llvm-project/pull/208173
None From 2891ff62aa1dae5b4371e273be2c63e2f2eae073 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= <[email protected]> Date: Wed, 8 Jul 2026 09:26:19 +0200 Subject: [PATCH] [clang][analyzer] Improved message in uninitialized.Assign at default assignment --- .../Checkers/UndefinedAssignmentChecker.cpp | 14 +++++++++++++ clang/test/Analysis/operator-calls.cpp | 20 +++++++++++++++---- 2 files changed, 30 insertions(+), 4 deletions(-) diff --git a/clang/lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp index 7f8923c7c09fc..f97dd8ee67d57 100644 --- a/clang/lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp @@ -73,6 +73,20 @@ void UndefinedAssignmentChecker::checkBind(SVal location, SVal val, } } + if (const auto *MD = + dyn_cast<CXXMethodDecl>(C.getStackFrame()->getDecl())) { + if ((MD->isCopyAssignmentOperator() || + MD->isMoveAssignmentOperator()) && + MD->isDefaulted() && B->isAssignmentOp()) { + OS << "Value assigned to field '" + << cast<MemberExpr>(B->getRHS()->IgnoreImpCasts()) + ->getMemberDecl() + ->getName() + << "' in " << (!MD->isImplicit() ? "default" : "implicit") + << " assignment operator is uninitialized"; + break; + } + } ex = B->getRHS(); break; } diff --git a/clang/test/Analysis/operator-calls.cpp b/clang/test/Analysis/operator-calls.cpp index a89624d44ac42..5af0d72b60bc0 100644 --- a/clang/test/Analysis/operator-calls.cpp +++ b/clang/test/Analysis/operator-calls.cpp @@ -111,6 +111,11 @@ namespace SynthesizedAssignment { B& operator=(B&&) = default; }; + struct C { + int x; + A a[3]; + }; + // This used to produce a warning about the iteration variable in the // synthesized assignment operator being undefined. // @@ -121,16 +126,16 @@ namespace SynthesizedAssignment { void testNoWarning() { B v, u; - u = v; // expected-warning@110{{Assigned value is uninitialized}} + u = v; // expected-warning@110{{Value assigned to field 'x' in default assignment operator is uninitialized}} // expected-note@-1{{Calling defaulted copy assignment operator for 'B'}} - // expected-note@110{{Assigned value is uninitialized}} + // expected-note@110{{Value assigned to field 'x' in default assignment operator is uninitialized}} } void testNoWarningMove() { B v, u; - u = static_cast<B &&>(v); // expected-warning@111{{Assigned value is uninitialized}} + u = static_cast<B &&>(v); // expected-warning@111{{Value assigned to field 'x' in default assignment operator is uninitialized}} // expected-note@-1{{Calling defaulted move assignment operator for 'B'}} - // expected-note@111{{Assigned value is uninitialized}} + // expected-note@111{{Value assigned to field 'x' in default assignment operator is uninitialized}} } void testConsistency() { @@ -162,4 +167,11 @@ namespace SynthesizedAssignment { clang_analyzer_eval(u.a[2].a == 43); // expected-warning{{TRUE}} // expected-note@-1{{TRUE}} } + + void testImplicitAssign() { + C c1, c2; + c1 = c2; // expected-warning@114{{Value assigned to field 'x' in implicit assignment operator is uninitialized}} + // expected-note@-1{{Calling implicit copy assignment operator for 'C'}} + // expected-note@114{{Value assigned to field 'x' in implicit assignment operator is uninitialized}} + } } _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
