================

----------------
tarunprabhu wrote:

The `DEFAULT`, `DISABLE`, and `DISABLE-LAST` prefixes are all checking for 
identical conditions. It may be better to have a single prefix for these, 
perhaps called `DISABLED`. The same could be done for `ENABLE` and 
`ENABLE-LAST` that are identical. 

You could also consider using `-SAME` instead of a wildcard match. For instance

```fortran
ENABLE: "-fc1"
ENABLE-SAME: "-freal-sum-association"
```

IMO, this makes it clearer about what each test expects, and suggests which are 
testing for equivalent behavior.

https://github.com/llvm/llvm-project/pull/207377
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to