AaronBallman wrote: > > Added a release note. `LCOMPILER-2423` is an AMD internal issue ID, similar > > to Apple’s `rdar` references. > > Can we just remove it please? We tolerate Apple's radr links for historical > reasons (and frankly, I don't really), but I very much don't want our commit > messages to start having everyone's internal bug tracker IDs in it. So let us > not set the precedence here.
FWIW, I share the concern about adding everyone's internal bug tracker IDs to commit messages. We have a lot of downstreams with their own bug trackers and so this really doesn't scale well. That said, our developer policy explicitly allows it (https://llvm.org/docs/DeveloperPolicy.html#commit-messages) and we got there after a bunch of community discussion on an RFC on the topic, so I don't think we should block people using this kind of metadata without another RFC asking to change the policy. @yxsamliu is this an internal push at AMD to start adding that metadata, or just a one-off thing? If it's one-off, then maybe dropping the metadata would be a kindness. But if it's a push, that'd be good for us to know so we can mentally prepare ourselves for seeing it more often as reviewers (and it might stop someone from writing an RFC to change the policy, if anyone was thinking of doing so). https://github.com/llvm/llvm-project/pull/208062 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
