AaronBallman wrote: > 1. I see that `warn_deprecated_capture_by_special_entity` is not added to any > diag group. So `-Wno-deprecated-attributes` would not work at the moment. So > it should be added to `DeprecatedAttributes` diag group.
What I see is: ``` def warn_deprecated_capture_by_special_entity : Warning< "'lifetime_capture_by(%0)' is deprecated; use '%1' instead">, InGroup<DeprecatedAttributes>; ``` which is in that group? > 2. I am actually in favour of having a subgroup under > `-Wdeprecated-attributes` (say `-Wdeprecated-attributes-lifetime-capture-by`) > because `-Wno-deprecated-attributes` might be too wide and users may miss > future deprecations since these silences tend to stay for long. In the > next-next release, we would remove support of this spelling completely and > would remove the sub-category as well making this a hard-error. -1 Also, keep in mind that adding the diagnostic group just kicks the can down the road -- when we eventually remove the deprecated attributes, there's no more need for the warning, but removing the warning now means anyone mentioning the warning group on the command line gets additional diagnostics about the unknown warning group. https://github.com/llvm/llvm-project/pull/196635 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
