tstellar wrote: > In addition, while Intel seems to keep up with upstream LLVM, AMD is a bit > behind > (https://github.com/ROCm/llvm-project/blob/9abbec66bfa34922521ef88fad1d6fcd43c1c462/clang/lib/Driver/ToolChains/Gnu.cpp#L2298). > So we end up with say, the system installed Clang/LLVM@v17, finding the GCC > toolset 13, but the recent amdclang (ROCm 7) finding only gcc-toolset-12.
I don't think this patch is actually going to fix this problem, because you if you are relying on the driver to select the gcc-toolset version for you then older clang builds are still going to select older gcc-toolset versions. This should be fixed either with: 1. config files/cflags that specify the exact gcc-toolset version you want (I know this may be difficult, but you are always going to run into problems if you aren't explicit) or 2. by making this check dynamic so that it always selects the newest gcc-toolset by default (although this still won't fix your problem until other vendors update to a version that does the dynamic checking also). https://github.com/llvm/llvm-project/pull/178459 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
