Author: Paul Kirth Date: 2026-07-10T14:49:16-07:00 New Revision: 1dbefed159e96e875e1f898093c8e872ab760035
URL: https://github.com/llvm/llvm-project/commit/1dbefed159e96e875e1f898093c8e872ab760035 DIFF: https://github.com/llvm/llvm-project/commit/1dbefed159e96e875e1f898093c8e872ab760035.diff LOG: [clang-doc][nfc] Remove stale FIXME (#208795) This was fixed a long time ago when relanding arena support. This FIXME was missed when we folded in the deep copying to the reland. It can safely be removed, as the situation it warns about cannot happen anymore. Added: Modified: clang-tools-extra/clang-doc/Representation.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clang-doc/Representation.cpp b/clang-tools-extra/clang-doc/Representation.cpp index 414b5a2377bcf..e71b3ddad78a8 100644 --- a/clang-tools-extra/clang-doc/Representation.cpp +++ b/clang-tools-extra/clang-doc/Representation.cpp @@ -485,11 +485,6 @@ void NamespaceInfo::merge(NamespaceInfo &&Other) { RecordInfo::RecordInfo(SymbolID USR, StringRef Name, StringRef Path) : SymbolInfo(InfoType::IT_record, USR, Name, Path) {} -// FIXME: This constructor is currently unsafe for cross-arena copies of -// populated records. Because a default copy of ScopeChildren will shallow-copy -// the intrusive pointers, leading to a use-after-free when the TransientArena -// is reset. Subsequent patches will address this by deep-copying children -// individually via reduceChildren. RecordInfo::RecordInfo(const RecordInfo &Other, llvm::BumpPtrAllocator &Arena) : SymbolInfo(Other, Arena), TagType(Other.TagType), IsTypeDef(Other.IsTypeDef) { _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
