kikairoya wrote:

Thank you for the update.

Please keep the commit history rather than squashing manually, that makes 
reviewing the changes harder.
Squashing is always done by GitHub, obtaining the commit message from the 
description text and gathering co-authors from stacked commits (I have never 
done it since I don't have the commit access, though).
See https://llvm.org/docs/GitHub.html#updating-pull-requests and the following 
sections.

I would appreciate it if you would restore the history from your local reflog 
that pointing just before squashing.

https://github.com/llvm/llvm-project/pull/147960
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to