Author: Wenju He Date: 2026-07-13T07:20:19+08:00 New Revision: b6e77d6af14b6b4d0d98248c1579b1be0194187a
URL: https://github.com/llvm/llvm-project/commit/b6e77d6af14b6b4d0d98248c1579b1be0194187a DIFF: https://github.com/llvm/llvm-project/commit/b6e77d6af14b6b4d0d98248c1579b1be0194187a.diff LOG: [Clang][Test] Fix -Wctad-maybe-unsupported in OperatorNewDeletePointersExtractorTest.cpp (#209012) Fix warning: `'std::set' may not intend to support class template argument deduction [-Wctad-maybe-unsupported]`, which is error under -Werror. std::set{*PtrId} does implicitly deduce to std::set<EntityId>, but it is not explicit or user-defined CATD guide. Opt-in warning -Wctad-maybe-unsupported flags it as maybe unsafe and unintended. The warning is enabled at https://github.com/llvm/llvm-project/blob/9083925dadb4/llvm/cmake/modules/HandleLLVMOptions.cmake#L977 Relates to #206600. Added: Modified: clang/unittests/ScalableStaticAnalysis/Analyses/OperatorNewDelete/OperatorNewDeletePointersExtractorTest.cpp Removed: ################################################################################ diff --git a/clang/unittests/ScalableStaticAnalysis/Analyses/OperatorNewDelete/OperatorNewDeletePointersExtractorTest.cpp b/clang/unittests/ScalableStaticAnalysis/Analyses/OperatorNewDelete/OperatorNewDeletePointersExtractorTest.cpp index d8b9bef9b65bb..055e599e1af43 100644 --- a/clang/unittests/ScalableStaticAnalysis/Analyses/OperatorNewDelete/OperatorNewDeletePointersExtractorTest.cpp +++ b/clang/unittests/ScalableStaticAnalysis/Analyses/OperatorNewDelete/OperatorNewDeletePointersExtractorTest.cpp @@ -150,7 +150,7 @@ TEST_F(OperatorNewDeletePointersExtractorTest, FreeOperatorDelete) { ASSERT_TRUE(PtrId); - EXPECT_EQ(*S, std::set{*PtrId}); + EXPECT_EQ(*S, std::set<EntityId>{*PtrId}); } TEST_F(OperatorNewDeletePointersExtractorTest, MemberOperatorDelete) { @@ -168,7 +168,7 @@ TEST_F(OperatorNewDeletePointersExtractorTest, MemberOperatorDelete) { auto PId = getEntityId("p"); ASSERT_TRUE(PId); - EXPECT_EQ(*S, std::set{*PId}); + EXPECT_EQ(*S, std::set<EntityId>{*PId}); } TEST_F(OperatorNewDeletePointersExtractorTest, OperatorDeleteArray) { @@ -184,7 +184,7 @@ TEST_F(OperatorNewDeletePointersExtractorTest, OperatorDeleteArray) { auto PId = getEntityId("p"); ASSERT_TRUE(PId); - EXPECT_EQ(*S, std::set{*PId}); + EXPECT_EQ(*S, std::set<EntityId>{*PId}); } TEST_F(OperatorNewDeletePointersExtractorTest, OperatorNew) { @@ -201,7 +201,7 @@ TEST_F(OperatorNewDeletePointersExtractorTest, OperatorNew) { auto RetId = getEntityIdForReturn("operator new"); ASSERT_TRUE(RetId); - EXPECT_EQ(*S, std::set{*RetId}); + EXPECT_EQ(*S, std::set<EntityId>{*RetId}); } TEST_F(OperatorNewDeletePointersExtractorTest, PlacementNew) { @@ -222,7 +222,7 @@ TEST_F(OperatorNewDeletePointersExtractorTest, PlacementNew) { ASSERT_TRUE(PlacementId); ASSERT_TRUE(RetId); - EXPECT_EQ(*S, (std::set{*PlacementId, *RetId})); + EXPECT_EQ(*S, (std::set<EntityId>{*PlacementId, *RetId})); } TEST_F(OperatorNewDeletePointersExtractorTest, PlacementDelete) { @@ -242,7 +242,7 @@ TEST_F(OperatorNewDeletePointersExtractorTest, PlacementDelete) { ASSERT_TRUE(PtrId); ASSERT_TRUE(PlacementId); - EXPECT_EQ(*S, (std::set{*PtrId, *PlacementId})); + EXPECT_EQ(*S, (std::set<EntityId>{*PtrId, *PlacementId})); } TEST_F(OperatorNewDeletePointersExtractorTest, NoOperatorNewOrDeleteSummary) { _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
