llvmorg-github-actions[bot] wrote:

<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Kyungtak Woo (kevinwkt)

<details>
<summary>Changes</summary>

Explicitly pass -fopenmp=libomp in the test to make it robust against 
downstream configurations where the default OpenMP runtime is set to something 
else (e.g., libgomp). Seems this is in alignment with other tests in 
`clang/test/Driver`. 

---
Full diff: https://github.com/llvm/llvm-project/pull/209082.diff


1 Files Affected:

- (modified) clang/test/Driver/amdgpu-openmp-gpu-max-threads-per-block.c (+1-1) 


``````````diff
diff --git a/clang/test/Driver/amdgpu-openmp-gpu-max-threads-per-block.c 
b/clang/test/Driver/amdgpu-openmp-gpu-max-threads-per-block.c
index ba5dd4c24a0bd..85bf4fc75dca3 100644
--- a/clang/test/Driver/amdgpu-openmp-gpu-max-threads-per-block.c
+++ b/clang/test/Driver/amdgpu-openmp-gpu-max-threads-per-block.c
@@ -1,5 +1,5 @@
 // Test that --gpu-max-threads-per-block is not ignored by openmp.
-// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp 
-fopenmp-targets=amdgcn-amd-amdhsa \
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp=libomp 
-fopenmp-targets=amdgcn-amd-amdhsa \
 // RUN:   --offload-arch=gfx906 -nogpulib --gpu-max-threads-per-block=256 %s 
2>&1 | FileCheck %s
 
 // CHECK: "-cc1" "-triple" "amdgcn-amd-amdhsa"

``````````

</details>


https://github.com/llvm/llvm-project/pull/209082
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to