https://github.com/NagyDonat commented:
Reviewing this PR would consume a significant amount of effort from me (because it is not small and I'm completely unfamiliar with the SMT symbolic execution logic), and as our team does not use SMT symbolic execution (because it is unstable) I don't think I can fit reviewing this into my schedule. Visually (without understanding the logic) the change looks reasonable, so I would lean towards accepting it, because if it is limited to the SMT symbolic execution, it won't break anything stable. @steakhal Currently you have "Changes Requested" on this PR, feel free to approve or reject it based on your judgement. https://github.com/llvm/llvm-project/pull/205078 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
