JDevlieghere added inline comments.

================
Comment at: lib/CodeGen/CGBlocks.cpp:1651
   StartFunction(FD, C.VoidTy, Fn, FI, args);
-  // Create a scope with an artificial location for the body of this function.
-  auto AL = ApplyDebugLocation::CreateArtificial(*this);
+  ApplyDebugLocation NL{*this, blockInfo.getBlockExpr()->getLocStart()};
   llvm::Type *structPtrTy = blockInfo.StructureType->getPointerTo();
----------------
vsk wrote:
> JDevlieghere wrote:
> > You probably have a good reason for doing so, but why do we need 
> > {}-initialization? 
> It's just a personal idiosyncrasy. I like braced-init because it doesn't have 
> a vexing parse issue, it works with list/aggregate init, and it makes it 
> clear that operator= isn't being called.
Fair enough. Thanks for clarifying!


https://reviews.llvm.org/D39310



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to