vgvassilev wrote:

> > Have you considered a larger change that might fix the whole initialization 
> > aspect of the parser: perhaps we could move it in the Action class itself...
> 
> I don't understand what exactly you mean. Are you talking about the need to 
> call `Parser::Initialize()` and to call it at a specific time? Because with 
> `Initialize()` called from the constructor both of those parts are handled 
> automatically by creating a Parser (I guess, that is kinda a rationale for 
> constructors).

I was thinking to move the entire parser object under the frontend action class 
but that is much larger refactoring which I believe will drop the need for 
scattering Initialize and ConsumeToken around.

https://github.com/llvm/llvm-project/pull/208348
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to