sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
This looks great! Thanks for bearing with me. ================ Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:31 + /// A human readable title for the refactoring. + StringRef Title; +}; ---------------- nit: I think the RefactoringDescriptor literals are easier to understand if Title comes before Description, so they're terse --> verbose. But totally up to you. ================ Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:66 + "local-rename", + "Finds and renames symbols in code with no indexer support", "Rename"}; + return Descriptor; ---------------- nit: please wrap before the title. You can hint clang-format to wrap one-per-line by including a trailing comma in the init-list. Repository: rL LLVM https://reviews.llvm.org/D38985 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits