https://github.com/ArcsinX requested changes to this pull request.
In `UnresolvedName` structure description we see that [Name]((https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/IncludeFixer.h#L65)) is expected to be without `::`. Checking is there `::` doesn't look like a right direction to fix the problem. We need to understand why `::` appears inside the `UnresolvedName::Name`. clangd `UnresolvedName` from `DeclarationNameInfo` (which comes from `Sema::CorrectTypo`). So, some investigation need to be performed. Maybe `DeclarationNameInfo` is not correct (then we need to make a fix in the clang), or maybe we don't handle the typo correctly in `IncludeFixer::UnresolvedNameRecorder::CorrectTypo`. https://github.com/llvm/llvm-project/pull/212134 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
