mgcarrasco wrote: Hi! This comment was generated using [fuzz-fill](https://github.com/ROCm/fuzz-fill), a new tool we're building to help improve LLVM test coverage by spotting lines introduced in a PR that don't yet appear to be exercised by the full test suite, including any tests added in this PR.
Looking at PR head `640a1ac6de6a`, we found 2 lines added or modified here that we couldn't find a test for: 1. https://github.com/llvm/llvm-project/blob/640a1ac6de6acd451c557ad78aca6c3757ec35e8/llvm/lib/Target/SPIRV/SPIRVUtils.cpp#L565 2. https://github.com/llvm/llvm-project/blob/640a1ac6de6acd451c557ad78aca6c3757ec35e8/llvm/lib/Target/SPIRV/SPIRVUtils.cpp#L567 If it makes sense, adding a regression test that validates these lines would be great. And if any of them are already tested and we missed it, we'd love to hear so we can improve the tool. Feel free to give us some feedback on whether this review was useful from your perspective. Thanks! ---- I noticed the PR is in draft but wanted to still share it in case it was helpful. https://github.com/llvm/llvm-project/pull/213986 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
