steakhal wrote: I'm a bit unsatisfied with the way of testing this. IMO the `getIssueString` should be tested in a unittest, because it's nice and pure. How about creating a new unittest as `clang/unittests/Analysis/IssueHashTest.cpp` where we would assert that for a given Decl in a C++ snippet it produces the expected issue hash string.
IMO this would make it clear what's going on in the test than having some `ls` count not add up in LIT. https://github.com/llvm/llvm-project/pull/214102 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
