github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp --
clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp
clang-tools-extra/test/clang-tidy/checkers/bugprone/implicit-widening-of-multiplication-result-short.cpp
--diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git
a/clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp
b/clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp
index fea7a650b..887326672 100644
---
a/clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp
+++
b/clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp
@@ -142,13 +142,12 @@ void
ImplicitWideningOfMultiplicationResultCheck::handleImplicitCastExpr(
RHS->IgnoreImpCasts()->getType()->isUnsignedIntegerType();
const bool EffectiveETyIsSigned =
ETy->isSignedIntegerType() && !BothOperandsWereUnsigned;
- if (Ty->isSignedIntegerType() == EffectiveETyIsSigned) {
+ if (Ty->isSignedIntegerType() == EffectiveETyIsSigned)
WideExprTy = Ty;
- } else if (Ty->isSignedIntegerType()) {
+ else if (Ty->isSignedIntegerType())
WideExprTy = Context->getCorrespondingUnsignedType(Ty);
- } else {
+ else
WideExprTy = Context->getCorrespondingSignedType(Ty);
- }
{
const auto Diag =
``````````
</details>
https://github.com/llvm/llvm-project/pull/214501
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
