smeenai added inline comments.

================
Comment at: lib/Driver/Driver.cpp:3884
+        const auto A = Args.getLastArgValue(options::OPT_fuse_ld_EQ, "link");
+        if (A.equals_lower("link") || A.equals_lower("lld"))
+          TC =
----------------
`lld-link` is a valid invocation for LLD as well, so I'd either add that 
option, change the equality option to a start check, or invert the check and 
check for an `-fuse-ld=` option starting with `bfd` (since we want the MSVC 
toolchain to be the default).


https://reviews.llvm.org/D39509



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to