================
@@ -41,20 +41,43 @@ static uint64_t getTimestampMillis() {
 #endif
 }
 
+#ifdef _WIN32
+// Write to files opened with OF_Append may not be guaranteed to be atomic
+// on Windows. Both openLogFile and writeLineToFD are noops on Windows.
+static int openLogFile(StringRef Path) {
----------------
cyndyishida wrote:

Is it possible to restructure this to an early exit/llvm_unreachable if the 
logger is enabled on Windows in a centralized way? So you won't need to 
conditionalize different control flows.

https://github.com/llvm/llvm-project/pull/211966
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to