craig.topper added inline comments.
================ Comment at: lib/Headers/avx512vlbwintrin.h:2801 + return _mm_mask_cmp_epi8_mask (__U, _mm_and_si128 (__A, __B), + _mm_setzero_hi(), 4); } ---------------- craig.topper wrote: > Sorry I didn't catch this before, but can you use _MM_CMPINT_NE and > _MM_CMPINT_EQ instead of '4' and '0' in all of these? Then no one has to > guess what 4 and 0 means. Better yet, use _mm512_cmpneq_epi32_mask, __mm512_cmpeq_epi32_mask and friends https://reviews.llvm.org/D38737 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
