dcoughlin added inline comments.
================ Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:26 +/// results in an ElementRegion. +static void conjureOffsetSymbolOnLocation( + SVal &Symbol, SVal Other, Expr* Expression, SValBuilder &svalBuilder, ---------------- I think it would be more clear at the call site what the inputs and output are if this function returned the conjured SVal (or 'Symbol' if it wouldn't be conjured). It would also be good to describe the role of the parameters in the doxygen comment. https://reviews.llvm.org/D39584 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
