tra added inline comments.

================
Comment at: test/Driver/cuda-bail-out.cu:31
+// CHECK-TWO-ARCHES-NOT: Error during compilation for sm_60
+// CHECK-TWO-ARCHES-NOT Error during host compilation
----------------
Missing ':' after CHECK-TWO-ARCHES-NOT.

You may want to include a compilation for a GPU arch that does *not* fail. 
Otherwise this test would be happy if we'd always fail during first device-side 
compilation. I believe we compile GPU arches in sorted order, so using 
--cuda-gpu-arch=sm_30 should work for this purpose.

E.g. something like this:
```
#ifdef __CUDA_ARCH__ == 300
#warning  OK. No error during compilation for sm_30.
#endif
```


https://reviews.llvm.org/D39502



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to