https://github.com/Xazax-hun approved this pull request.
Overall, it looks good to me. But I still think the AST is confusing and we probably should have a separate node to represent what `CXXThisExpr` is in an `CXXDefaultInitExpr`. We are using the same node for two very different semantics and that makes consuming the AST harder. But changing the AST is out of scope for this PR so I think this is OK to land as is and fixing the AST could be follow-up work. https://github.com/llvm/llvm-project/pull/146900 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
