DanielCChen wrote: > Do you consider this PR ready to move out of draft? If it stays a draft for > now, would you like reviewers to keep leaving comments?
One of the reasons I keep this PR in the draft mode is that I still need to discuss with the author of https://github.com/llvm/llvm-project/pull/159788 to see how we will collaborate with the two PRs. At the same time, I would love to receive review comments on the draft so I can patch the holes of this PR. > Several review rounds have produced substantive findings and follow-up > changes, so the patch set may still be evolving. If you're still iterating, > I'll wait until you mark it Ready for review before another pass. I really appreciate the thorough review and testing! It indeed improved the PR a lot! As you may have noticed, I marked the comments that I have addressed with a thumb up emoji. For those that don't have the emoji mark, I haven't gotten to them yet, but I will. Since some of the comments are independent to others, I will be grateful if you can verify the ones that I have addressed and see if there are other holes within that area. https://github.com/llvm/llvm-project/pull/216164 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
