ilya-biryukov added a comment.

I can see that `FixedCompilationDatabase` does not set a working directory. Is 
this something we may want to have for `compile_flags.txt` or one would need to 
resort to `compile_commands.json` to get this?
E.g., I'd find it useful to add includes with paths relative to 
`compile_flags.txt` by putting `-Iproject-dep/include` there.



================
Comment at: lib/Tooling/CompilationDatabase.cpp:322
+      llvm::line_iterator()};
+  return std::unique_ptr<FixedCompilationDatabase>(new 
FixedCompilationDatabase(
+      llvm::sys::path::parent_path(Path), std::move(Args)));
----------------
Maybe use `llvm:make_unique`?


https://reviews.llvm.org/D39799



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to