klimek added a comment. In https://reviews.llvm.org/D39836#920313, @sammccall wrote:
> In https://reviews.llvm.org/D39836#920306, @ilya-biryukov wrote: > > > I personally think they're useful to have anyway, and they don't add much > > noise when they're at the end of completions list. > > I sometimes want to complete an item I know is there and then fix > > accessibility. Do you think they add too much noise? > > > For me the noise definitely outweighs the value, e.g. when I'm trying to see > all the available functions. There are costs beyond noise: > > - they bulk up tests and debugging output > - they complicate the scoring scheme - we *never* want them to appear above a > legal completion, so a 1-dimensional score needs special handling as here. > - compute: we spend time scoring them, computing their strings, writing them > over the wire, and then the client has to process them I do think they are useful to me, but I don't know what the percentages of folks who want them vs. not are, and whether people have actually tried multiple schemes. I think it's more likely that we get bug reports to put them in if we don't show them than the other way round, so I think taking them out is a good way to get that feedback :) https://reviews.llvm.org/D39836 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits