================
@@ -222,7 +222,7 @@ class CheckerContext {
                const ProgramPointTag *Tag = nullptr) {
     if (!State)
       State = getState();
-    addTransition(State, generateSink(State, getPredecessor()));
+    generateSink(State, getPredecessor());
----------------
NagyDonat wrote:

I intend to redesign the node creation interface provided by `CheckerContext` 
(to e.g. remove the redundancy between `generateSink`, `addSink` and 
`generateErrorNode`) and I'll soon open a discourse thread for this.

As this redesign would either remove `äddSink` or redesign its signature, I 
don't want to rush forwarding `Tag` (which is never specified by any caller).

Also note that tagging a sink node is not very useful, note tags are only 
useful on non-sink nodes (where they can appear on a bug path), while a tag on 
a sink node can only serve debugging purposes.

https://github.com/llvm/llvm-project/pull/218970
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to